Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] improve fingerprint UX #2675

Merged
merged 5 commits into from
Nov 9, 2024
Merged

[eas-cli] improve fingerprint UX #2675

merged 5 commits into from
Nov 9, 2024

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Nov 6, 2024 •
edited
Loading

Why

This PR does the following:

How

Compressing project files and uploading to EAS Build. Learn more: https://expo.fyi/eas-build-archive
✔ Uploaded to EAS 
⌛️ Computing project fingerprint taking longer than expected...
⏩ To skip this step, set the environment variable: EAS_SKIP_AUTO_FINGERPRINT=1
✔ Computed project fingerprint

Test Plan

  • Tested a fingerprint computation that 'takes too long' (await 5 second promise)
  • Tested a fast fingerprint computation
  • Tested eas build with and without EAS_SKIP_AUTO_FINGERPRINT=1

@quinlanj quinlanj changed the title @quin/fingerprint logs [eas-cli] improve fingerprint UX Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

Generated by CodeMention

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Size Change: +656 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +656 B (0%)

compressed-size-action

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (c30c1cd) to head (6402f90).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/utils/fingerprintCli.ts 7.70% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
- Coverage   52.97%   52.94%   -0.03%     
==========================================
  Files         576      576              
  Lines       22084    22101      +17     
  Branches     4334     4335       +1     
==========================================
+ Hits        11697    11699       +2     
- Misses      10353    10368      +15     
  Partials       34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

szdziedzic
szdziedzic requested changes Nov 7, 2024
View reviewed changes
packages/eas-cli/src/utils/fingerprintCli.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/utils/fingerprintCli.ts Outdated Show resolved Hide resolved
@quinlanj quinlanj requested a review from szdziedzic November 7, 2024 20:38
wschurman
wschurman approved these changes Nov 7, 2024
View reviewed changes
packages/eas-cli/src/utils/fingerprintCli.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/utils/fingerprintCli.ts
if (options.debug) {
fingerprintOptions.debug = true;
}
const fingerprint = await Fingerprint.createFingerprintAsync(projectDir, fingerprintOptions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot this when I was reviewing the other PR re: doing a function call directly vs CLI call. One additional consideration/benefit of CLI is the process/subprocess model of using the CLI via spawn instead of a direct function call. By having this be in a subprocess rather than the CLI process, we could monitor that and even kill it with a Promise.race if it's taking too long (I think?).

@quinlanj quinlanj force-pushed the @quin/fingerprintLogs branch from 1e18121 to 6402f90 Compare November 8, 2024 23:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit 027d362 into main Nov 9, 2024
10 checks passed
@quinlanj quinlanj deleted the @quin/fingerprintLogs branch November 9, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szdziedzic szdziedzic szdziedzic approved these changes

@wschurman wschurman wschurman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quinlanj @wschurman @szdziedzic